Exclude observe-auto issues from reflect ledger parsing#585
Exclude observe-auto issues from reflect ledger parsing#585tristanmanchester wants to merge 1 commit into
Conversation
|
Thanks for the fix. I accepted the underlying issue, but implemented it with changes on this branch in 589216d0 rather than merging this PR directly. Decision: IMPLEMENT_WITH_CHANGES. Reflect disposition parsing now uses the same accounting ID set that excludes observe-auto skips, and fresh reflect persistence preserves existing observe_auto decisions instead of clearing their decision, target, and source. I added an end-to-end persistence regression to cover the case Stage 1 called out. Validation: PYENV_VERSION=3.11.11 python -m pytest desloppify/tests/commands/plan/test_reflect_disposition_ledger.py desloppify/tests/commands/plan/test_triage_runner.py desloppify/tests/commands/plan/test_triage_split_modules_direct.py desloppify/tests/commands/plan/test_triage_stage_flow_observe_reflect_organize_direct.py desloppify/tests/plan/test_unified_disposition_map.py -q |
|
Closing as superseded by 589216d0 on the review branch. |
2 participants
Summary
accounting_idsrather thanvalid_idswhen parsing the reflect coverage ledgerdecision_sourcestays preservedTesting
uv run --with pytest python -m pytest desloppify/tests/commands/plan/test_triage_stage_flow_observe_reflect_organize_direct.py -k "reflect_rejects_incomplete_issue_accounting or excludes_observe_auto_from_disposition_ledger"